Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-868] Update SEND message header and content to the new design system #5431

Merged
merged 24 commits into from
Jan 29, 2024

Conversation

adelloste
Copy link
Member

@adelloste adelloste commented Jan 24, 2024

Short description

This PR updates the header and content of a SEND message.

NOTE: Other PRs will follow to update the rest of the message.

Details

message details

List of changes proposed in this pull request

  • added MessageDetailHeader
  • updated MessageDetailsContent
  • added tests

How to test

Using the io-dev-api-server, generate a SEND message. Enable the design system and navigate to the message detail. Check that the content is displayed correctly.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-868] Update SEND message header and content to the new design system feat: [IOCOM-868] Update SEND message header and content to the new design system Jan 24, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jan 24, 2024

Affected stories

  • 🌟 IOCOM-868: [App] Adattare titolo, data e contenuto (markdown) del messaggio
    subtask of
    • IOCOM-814: Adottare il nuovo design system nel dettaglio di un messaggio di SEND

Generated by 🚫 dangerJS against 75db4cf

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (f47f87a) 47.12% compared to head (c2eb487) 47.29%.
Report is 1 commits behind head on master.

❗ Current head c2eb487 differs from pull request most recent head 75db4cf. Consider uploading reports for the commit 75db4cf to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5431      +/-   ##
==========================================
+ Coverage   47.12%   47.29%   +0.16%     
==========================================
  Files        1459     1463       +4     
  Lines       31315    31366      +51     
  Branches     7621     7628       +7     
==========================================
+ Hits        14757    14834      +77     
+ Misses      16500    16474      -26     
  Partials       58       58              
Files Coverage Δ
...s/components/MessageDetail/MessageDetailHeader.tsx 100.00% <100.00%> (ø)
...ures/pn/components/LegacyMessageDetailsContent.tsx 100.00% <100.00%> (ø)
ts/features/pn/components/MessageDetails.tsx 100.00% <100.00%> (+25.71%) ⬆️
...s/features/pn/components/MessageDetailsContent.tsx 100.00% <100.00%> (ø)
ts/features/pn/screens/MessageDetailsScreen.tsx 82.85% <100.00%> (+79.91%) ⬆️
ts/features/pn/store/types/transformers.ts 100.00% <ø> (+75.00%) ⬆️
ts/features/pn/navigation/navigator.tsx 28.57% <16.66%> (-38.10%) ⬇️
ts/features/pn/components/LegacyMessageDetails.tsx 74.28% <74.28%> (ø)
...features/pn/screens/LegacyMessageDetailsScreen.tsx 2.94% <2.94%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b690c7...75db4cf. Read the comment docs.

Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adelloste adelloste merged commit 5f5f644 into master Jan 29, 2024
6 checks passed
@adelloste adelloste deleted the IOCOM-868-message-header branch January 29, 2024 14:56
adelloste added a commit that referenced this pull request Jan 30, 2024
This PR depends on #5431

## Short description
This PR updates the `MessageDetails` component in order to display the
tags.

_NOTE: Other PRs will follow to update the rest of the message._

<details open><summary>Details</summary>
<p>

| MessageDetails |
| - |
| <img
src="https://github.com/pagopa/io-app/assets/29163287/3df211d0-43fa-460a-b7a7-b2ef0a514f41"
width="300"/> |

</p>
</details> 

## List of changes proposed in this pull request
- added the tags in the header of the SEND message

## How to test
Using the `io-dev-api-server`, generate a SEND message. Enable the
design system and navigate to the message details. Check that the
content is displayed correctly.

---------

Co-authored-by: Andrea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants